From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 2/2] add f_flags to struct statfs(64)
Date: Tue, 29 Jun 2010 08:57:02 -0400
Message-ID: <20100629125702.GA11463@infradead.org>
References: <20100626093507.GB26371@lst.de>
 <60FB0305-A632-4A63-9BD8-DA07CC69B7D7@dilger.ca>
 <4C28FD98.1010300@redhat.com>
 <20100629085759.GN28364@laptop>
 <4C29C3F9.7030805@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nick Piggin <npiggin@suse.de>, Andreas Dilger <adilger@dilger.ca>,
	Christoph Hellwig <hch@lst.de>, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org
To: Ulrich Drepper <drepper@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:56710 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755122Ab0F2M5S (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 29 Jun 2010 08:57:18 -0400
Content-Disposition: inline
In-Reply-To: <4C29C3F9.7030805@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jun 29, 2010 at 02:59:21AM -0700, Ulrich Drepper wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 06/29/2010 01:57 AM, Nick Piggin wrote:
> > ST_VALID is required to differentiate between no flags, and
> > flags field unsupported of course.
> 
> Not needed if a new syscall would be used.

True.  But if we add a new syscall anyway I'd rather implement the
glibc statvfs64 structure directly.  The gives filesystem which
really want to a chance to implement f_favail, and we could also
store the full uuid in the f_spare fields now that we have more space.