From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 29/52] fs: icache lock i_count Date: Sat, 3 Jul 2010 15:18:16 +1000 Message-ID: <20100703051816.GG11732@laptop> References: <20100624030212.676457061@suse.de> <20100624030730.245992858@suse.de> <20100630072702.GF24712@dastard> <20100630120502.GB21358@laptop> <20100702190355.2b3fe6d2.akpm@linux-foundation.org> <20100703034123.GE11732@laptop> <20100702213149.f0ca2f72.akpm@linux-foundation.org> <20100703050652.GF11732@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dave Chinner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, John Stultz , Frank Mayhar To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20100703050652.GF11732@laptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Sat, Jul 03, 2010 at 03:06:52PM +1000, Nick Piggin wrote: > It is possible that locking can be reduced if some things are verified > and carefully shown not to matter. I just don't see the need yet and it > would make things overly complicated I think. Introducing any more > complexity will sink this patchset. By overly complicated, I mean, for this patchset where locking is already been rewritten. It would then be no more complicated (actually far less) than equivalently trying to lift inode_lock from parts of the code where it is causing contention times.