From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/6] block: push down BKL into .locked_ioctl Date: Tue, 6 Jul 2010 21:52:07 -0400 Message-ID: <20100707015207.GE2950@infradead.org> References: <1278193640-24223-1-git-send-email-arnd@arndb.de> <1278193640-24223-2-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, John Kacur , Frederic Weisbecker , linux-scsi@vger.kernel.org To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <1278193640-24223-2-git-send-email-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Looking at this again I don't like the foo_unlock_ioctl naming you're adding. Just rename the existing ioctl routines to foo_locked_ioctl or move the lock_kernel/unlock_kernel calls into the function, which would be even better.