From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 2/3] writeback: Add tracing to balance_dirty_pages
Date: Wed, 7 Jul 2010 13:11:45 +1000
Message-ID: <20100707031145.GH25018@dastard>
References: <1278459715-25720-1-git-send-email-david@fromorbit.com>
 <1278459715-25720-3-git-send-email-david@fromorbit.com>
 <20100707022055.GB17385@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: axboe@kernel.dk, linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bld-mail15.adl6.internode.on.net ([150.101.137.100]:49468 "EHLO
	mail.internode.on.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752247Ab0GGDLt (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 6 Jul 2010 23:11:49 -0400
Content-Disposition: inline
In-Reply-To: <20100707022055.GB17385@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jul 06, 2010 at 10:20:55PM -0400, Christoph Hellwig wrote:
> > +
> > +	TP_fast_assign(
> > +		char *__no_bdi = "(no bdi)";
> > +
> > +		if (bdi)
> > +			strncpy(__entry->name, dev_name(bdi->dev), 32);
> > +		else
> > +			strncpy(__entry->name, __no_bdi, 32);
> 
> I can't see a caller that doesn't have a bdi.

True. I think that was left over from the previous version where
the bdi could be null. I'll fix it up.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com