From: Christoph Hellwig <hch@lst.de>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] simplify writeback thread creation
Date: Thu, 8 Jul 2010 20:48:11 +0200 [thread overview]
Message-ID: <20100708184811.GA17593@lst.de> (raw)
In-Reply-To: <1278614602.7365.8.camel@localhost.localdomain>
On Thu, Jul 08, 2010 at 09:43:22PM +0300, Artem Bityutskiy wrote:
> Hmm, was thinking about this while driving home - the forker approach
> has a good resilience property - if it cannot fork - it'll do the stuff
> itself. I have a feeling that if something like this to be implemented
> with the approach I suggested, we'll end up with similar level of
> complexity that we wanted to get rid of...
Yes, the lazy starting is what adds the complexity. I think starting
it once we have any filesystem mounted on the bdi and stop it once all
filesystems are gone is a lot simpler and more elegant. It also solves
the other issue wit hall lazy schemes, that is the race betwen dirtying
data with no alive thread and the bdi going away. The current code
tries to deal with that by splicing the remaining dirty inodes to the
default BDI, but that'll just cause memory corruption in most cases,
because the BDI is references all over the writeback code and it's
gone by the point it'll actually go away. Which makes be believe this
race is a rather theoretical one.
next prev parent reply other threads:[~2010-07-08 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 22:52 [PATCH, RFC] simplify writeback thread creation Christoph Hellwig
2010-07-08 7:08 ` Artem Bityutskiy
2010-07-08 12:20 ` Jens Axboe
2010-07-08 14:21 ` Artem Bityutskiy
2010-07-08 14:59 ` Jens Axboe
2010-07-08 15:23 ` Artem Bityutskiy
2010-07-08 17:23 ` Jens Axboe
2010-07-08 18:43 ` Artem Bityutskiy
2010-07-08 18:48 ` Christoph Hellwig [this message]
2010-07-09 7:52 ` Artem Bityutskiy
2010-07-09 8:16 ` Jens Axboe
2010-07-09 11:06 ` Theodore Tso
2010-07-09 14:51 ` Christoph Hellwig
2010-07-09 15:49 ` Artem Bityutskiy
2010-07-08 13:22 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100708184811.GA17593@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).