From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] mm: add context argument to shrinker callback Date: Thu, 15 Jul 2010 14:09:46 -0400 Message-ID: <20100715180946.GA14554@infradead.org> References: <1279194418-16119-1-git-send-email-david@fromorbit.com> <1279194418-16119-2-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <1279194418-16119-2-git-send-email-david@fromorbit.com> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jul 15, 2010 at 09:46:56PM +1000, Dave Chinner wrote: > From: Dave Chinner > > The current shrinker implementation requires the registered callback > to have global state to work from. This makes it difficult to shrink > caches that are not global (e.g. per-filesystem caches). Pass the shrinker > structure to the callback so that users can embed the shrinker structure > in the context the shrinker needs to operate on and get back to it in the > callback via container_of(). > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org