From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [RFC][PATCH 02/16] writeback: remove redundant list initialization Date: Sun, 18 Jul 2010 02:44:49 -0400 Message-ID: <20100718064449.GB23811@infradead.org> References: <1279284312-2411-1-git-send-email-dedekind1@gmail.com> <1279284312-2411-3-git-send-email-dedekind1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Artem Bityutskiy Return-path: Content-Disposition: inline In-Reply-To: <1279284312-2411-3-git-send-email-dedekind1@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jul 16, 2010 at 03:44:58PM +0300, Artem Bityutskiy wrote: > From: Artem Bityutskiy > > We do not have to call 'INIT_LIST_HEAD()' for list elements > ('bdi->bdi_list') before inserting them to the 'bdi_pending_list', > because 'list_add_tail' will initialize the element anyway. Thus, > kill the redundant initialization. Looks good, Reviewed-by: Christoph Hellwig