From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/8] vmscan: tracing: Update trace event to track if page reclaim IO is for anon or file pages Date: Mon, 19 Jul 2010 10:15:01 -0400 Message-ID: <20100719141501.GA12510@infradead.org> References: <1279545090-19169-1-git-send-email-mel@csn.ul.ie> <1279545090-19169-3-git-send-email-mel@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Dave Chinner , Chris Mason , Nick Piggin , Rik van Riel , Johannes Weiner , Christoph Hellwig , Wu Fengguang , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Andrew Morton , Andrea Arcangeli To: Mel Gorman Return-path: Content-Disposition: inline In-Reply-To: <1279545090-19169-3-git-send-email-mel@csn.ul.ie> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jul 19, 2010 at 02:11:24PM +0100, Mel Gorman wrote: > It is useful to distinguish between IO for anon and file pages. This > patch updates > vmscan-tracing-add-trace-event-when-a-page-is-written.patch to include > that information. The patches can be merged together. I think the trace would be nicer if you #define flags for both cases and then use __print_flags on them. That'll also make it more extensible in case we need to add more flags later. And a purely procedural question: This is supposed to get rolled into the original patch before it gets commited to a git tree, right? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org