From: Jan Kara <jack@suse.cz>
To: Jiaying Zhang <jiayingz@google.com>
Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org, mrubin@google.com,
tytso@mit.edu, c@google.com
Subject: Re: [PATCH, RFC] Change quota error message to print out disk and function name
Date: Tue, 20 Jul 2010 17:39:50 +0200 [thread overview]
Message-ID: <20100720153950.GA12998@quack.suse.cz> (raw)
In-Reply-To: <20100709013946.318871BC2B1@ruihe.smo.corp.google.com>
Hi,
On Thu 08-07-10 18:39:46, Jiaying Zhang wrote:
> The current quota error message doesn't always print the disk name, so
> it is hard to identify the "bad" disk when quota error happens.
>
> This patch changes the standardized quota error message to print out disk name
> and function name. It also uses a combination of cpp macro and inline function
> to provide better type checking and to lower the text size of the message.
Thanks for the patch. I've slightly modified the message to:
printk(KERN_ERR "Quota error (device %s): %s: ", ...)
and also you have to export __quota_error for quota format modules.
Otherwise I've included the patch in my tree.
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
prev parent reply other threads:[~2010-07-20 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 1:39 [PATCH, RFC] Change quota error message to print out disk and function name Jiaying Zhang
2010-07-20 15:39 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720153950.GA12998@quack.suse.cz \
--to=jack@suse.cz \
--cc=c@google.com \
--cc=jiayingz@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).