From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH, RFC] Change quota error message to print out disk and function name Date: Tue, 20 Jul 2010 17:39:50 +0200 Message-ID: <20100720153950.GA12998@quack.suse.cz> References: <20100709013946.318871BC2B1@ruihe.smo.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org, mrubin@google.com, tytso@mit.edu, c@google.com To: Jiaying Zhang Return-path: Received: from cantor2.suse.de ([195.135.220.15]:43005 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932356Ab0GTPkV (ORCPT ); Tue, 20 Jul 2010 11:40:21 -0400 Content-Disposition: inline In-Reply-To: <20100709013946.318871BC2B1@ruihe.smo.corp.google.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi, On Thu 08-07-10 18:39:46, Jiaying Zhang wrote: > The current quota error message doesn't always print the disk name, so > it is hard to identify the "bad" disk when quota error happens. > > This patch changes the standardized quota error message to print out disk name > and function name. It also uses a combination of cpp macro and inline function > to provide better type checking and to lower the text size of the message. Thanks for the patch. I've slightly modified the message to: printk(KERN_ERR "Quota error (device %s): %s: ", ...) and also you have to export __quota_error for quota format modules. Otherwise I've included the patch in my tree. Honza -- Jan Kara SUSE Labs, CR