From: Wu Fengguang <fengguang.wu@intel.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>
Subject: Re: [patch 3/5] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos
Date: Wed, 21 Jul 2010 11:10:14 +0800 [thread overview]
Message-ID: <20100721031014.GB9012@localhost> (raw)
In-Reply-To: <20100721115359.01b5d2b8.kamezawa.hiroyu@jp.fujitsu.com>
On Wed, Jul 21, 2010 at 10:53:59AM +0800, KAMEZAWA Hiroyuki wrote:
> On Wed, 21 Jul 2010 12:54:37 +1000
> Nick Piggin <npiggin@suse.de> wrote:
>
> > On Tue, Jul 20, 2010 at 03:29:48PM -0700, Andrew Morton wrote:
> > > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> > >
> > > Now, rw_verify_area() checsk f_pos is negative or not. And if negative,
> > > returns -EINVAL.
> > >
> > > But, some special files as /dev/(k)mem and /proc/<pid>/mem etc.. has
> > > negative offsets. And we can't do any access via read/write to the
> > > file(device).
> > >
> > > So introduce FMODE_NEG_OFFSET to allow negative file offsets.
> >
> > Minor nitpick but I don't understand why this is called NEG_OFFSET. It's
> > a large positive offset into the file so FMODE_UNSIGNED_OFFSET seems
> > like it would be better.
> >
> Ah, agreed.
Agreed too.
> I'll prepare a macro-renaming patch later (if this patch goes now.)
> Thank you for review.
Thanks,
Fengguang
next prev parent reply other threads:[~2010-07-21 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 22:29 [patch 3/5] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos akpm
2010-07-21 2:54 ` Nick Piggin
2010-07-21 2:53 ` KAMEZAWA Hiroyuki
2010-07-21 3:10 ` Wu Fengguang [this message]
2010-07-21 4:03 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2010-05-24 19:24 akpm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721031014.GB9012@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).