From: Christoph Hellwig <hch@infradead.org>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 09/11] writeback: restructure bdi forker loop a little
Date: Wed, 21 Jul 2010 08:02:50 -0400 [thread overview]
Message-ID: <20100721120250.GE28745@infradead.org> (raw)
In-Reply-To: <1279704706-1267-10-git-send-email-dedekind1@gmail.com>
On Wed, Jul 21, 2010 at 12:31:44PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> This patch re-structures the loop which walks bdi a little. This is just a
> micro-step towards the coming change where the forker thread will kill the bdi
> threads. It should simplify reviewing the following changes, which would
> otherwise be larger.
>
> This patch also adds the 'bdi_cap_flush_forker(bdi)' condition check to the
> loop. The reason for this is that the forker thread can start _before_ the
> 'BDI_registered' flag is set (see 'bdi_register()'), so the WARN() statement
> will fire for the default bdi. I observed this warning at boot-up.
>
> This patch also amends comments a little.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-07-21 12:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 9:31 [PATCHv2 00/16] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 01/11] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 02/11] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 03/11] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 04/11] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-21 11:57 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 05/11] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 06/11] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-21 12:01 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 07/11] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 08/11] writeback: move last_active to bdi Artem Bityutskiy
2010-07-21 9:31 ` [PATCHv2 09/11] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-21 12:02 ` Christoph Hellwig [this message]
2010-07-21 9:31 ` [PATCHv2 10/11] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-21 12:04 ` Christoph Hellwig
2010-07-21 9:31 ` [PATCHv2 11/11] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-21 11:45 ` Artem Bityutskiy
2010-07-22 0:41 ` Dave Chinner
2010-07-22 6:50 ` Artem Bityutskiy
2010-07-22 9:00 ` Christoph Hellwig
2010-07-22 9:24 ` Artem Bityutskiy
2010-07-22 13:27 ` Artem Bityutskiy
2010-07-21 12:12 ` Christoph Hellwig
2010-07-22 3:19 ` Nick Piggin
2010-07-22 6:48 ` Artem Bityutskiy
2010-07-22 7:22 ` Tero.Kristo
2010-07-22 8:07 ` Nick Piggin
2010-07-22 8:05 ` Nick Piggin
2010-07-22 8:02 ` Artem Bityutskiy
2010-07-22 8:59 ` Nick Piggin
2010-07-22 9:50 ` Artem Bityutskiy
2010-07-23 15:03 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100721120250.GE28745@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).