From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCHv4 10/14] writeback: move bdi threads exiting logic to the forker thread Date: Fri, 23 Jul 2010 12:23:11 -0400 Message-ID: <20100723162311.GA29633@infradead.org> References: <1279897554-1526-1-git-send-email-dedekind1@gmail.com> <1279897554-1526-11-git-send-email-dedekind1@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Artem Bityutskiy Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:51013 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983Ab0GWQXN (ORCPT ); Fri, 23 Jul 2010 12:23:13 -0400 Content-Disposition: inline In-Reply-To: <1279897554-1526-11-git-send-email-dedekind1@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Looks good, Reviewed-by: Christoph Hellwig Maybe bdi_forker_thread can be cleaned up a bit more by introducing a enum { NO_ACTION, START_THREAD, KILL_THREAD, } action; and then do a switch based on it later?