From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCHv4 13/14] writeback: remove unnecessary init_timer call
Date: Fri, 23 Jul 2010 12:28:11 -0400
Message-ID: <20100723162811.GC29633@infradead.org>
References: <1279897554-1526-1-git-send-email-dedekind1@gmail.com>
 <1279897554-1526-14-git-send-email-dedekind1@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jens Axboe <axboe@kernel.dk>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Artem Bityutskiy <dedekind1@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:60573 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758835Ab0GWQ2M (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 23 Jul 2010 12:28:12 -0400
Content-Disposition: inline
In-Reply-To: <1279897554-1526-14-git-send-email-dedekind1@gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Jul 23, 2010 at 06:05:53PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> 
> The 'setup_timer()' function also calls 'init_timer()', so the extra
> 'init_timer()' call is not needed. Indeed, 'setup_timer()' is basically
> 'init_timer()' plus callback function and data pointers initialization.

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>