From: Christoph Hellwig <hch@infradead.org>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 14/14] writeback: add new tracepoints
Date: Fri, 23 Jul 2010 12:29:19 -0400 [thread overview]
Message-ID: <20100723162919.GD29633@infradead.org> (raw)
In-Reply-To: <1279897554-1526-15-git-send-email-dedekind1@gmail.com>
On Fri, Jul 23, 2010 at 06:05:54PM +0300, Artem Bityutskiy wrote:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
>
> Add 2 new trace points to the periodic write-back wake up case, just like we do
> in the 'bdi_queue_work()' function. Namely, introduce:
>
> 1. trace_writeback_wakeup(bdi)
> 2. trace_writeback_wakeup_nothread(bdi)
>
> The first event is triggered every time we wake up a bdi thread to start
> periodic background write-out. The second event is triggered only when the bdi
> thread does not exist and should be created by the forker thread.
>
> This patch was suggested by Dave Chinner <david@fromorbit.com>
As mentioned before doing the wakeup just for the case where we
really wake up the flusher thead is much better. It's not 100%
clear for bdi_queue_work as we queue the work in either case, but
I'd prefer to fix that one up as well (not in your series anyway)
next prev parent reply other threads:[~2010-07-23 16:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 15:05 [PATCHv4 00/14] kill unnecessary bdi wakeups + cleanups Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 01/14] writeback: harmonize writeback threads naming Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 02/14] writeback: fix possible race when creating bdi threads Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 03/14] writeback: do not lose wake-ups in the forker thread - 1 Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 04/14] writeback: do not lose wake-ups in the forker thread - 2 Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 05/14] writeback: do not lose wake-ups in bdi threads Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 06/14] writeback: simplify bdi code a little Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 07/14] writeback: do not remove bdi from bdi_list Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 08/14] writeback: move last_active to bdi Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 09/14] writeback: restructure bdi forker loop a little Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 10/14] writeback: move bdi threads exiting logic to the forker thread Artem Bityutskiy
2010-07-23 16:23 ` Christoph Hellwig
2010-07-24 5:55 ` Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 11/14] writeback: prevent unnecessary bdi threads wakeups Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 12/14] writeback: optimize periodic bdi thread wakeups Artem Bityutskiy
2010-07-23 16:28 ` Christoph Hellwig
2010-07-24 6:00 ` Artem Bityutskiy
2010-07-23 15:05 ` [PATCHv4 13/14] writeback: remove unnecessary init_timer call Artem Bityutskiy
2010-07-23 16:28 ` Christoph Hellwig
2010-07-23 15:05 ` [PATCHv4 14/14] writeback: add new tracepoints Artem Bityutskiy
2010-07-23 16:29 ` Christoph Hellwig [this message]
2010-07-24 6:01 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100723162919.GD29633@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dedekind1@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).