From: Mike Snitzer <snitzer@redhat.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Jens Axboe <jaxboe@fusionio.com>,
Mikulas Patocka <mpatocka@redhat.com>,
dm-devel@redhat.com, Alasdair G Kergon <agk@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: disallow FS recursion from sb_issue_discard allocation
Date: Tue, 27 Jul 2010 11:33:52 -0400 [thread overview]
Message-ID: <20100727153352.GA5574@redhat.com> (raw)
In-Reply-To: <20100727134414.GC18966@thunk.org>
On Tue, Jul 27 2010 at 9:44am -0400,
Ted Ts'o <tytso@mit.edu> wrote:
> On Tue, Jul 06, 2010 at 12:11:56PM -0400, Mike Snitzer wrote:
> > Filesystems can call sb_issue_discard on a memory reclaim path
> > (e.g. ext4 calls sb_issue_discard during journal commit).
> >
> > Use GFP_NOFS in sb_issue_discard to avoid recursing back into the FS.
> >
> > Reported-by: Mikulas Patocka <mpatocka@redhat.com>
> > Signed-off-by: Mike Snitzer <snitzer@redhat.com>
>
> Hi Jens,
>
> I never saw an ack from you on this patch. Are you ok with it, and
> have you grabbed it for your tree? Do you want me to include this in
> the ext4 tree, even though it's a patch to include/linux/blkdev.h?
Hi Ted,
Thanks for following up on this. In my experience, Jens is more apt to
pick up a patch if it gets explicitly 'Acked-by' other stake-holders
(especially when a patch is motivated by another subsystem, in this case
the proposed block change addresses a problem unique to fs/ext4).
Mike
next prev parent reply other threads:[~2010-07-27 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.1007021107420.7296@hs20-bc2-1.build.redhat.com>
[not found] ` <Pine.LNX.4.64.1007021112340.7296@hs20-bc2-1.build.redhat.com>
[not found] ` <Pine.LNX.4.64.1007021117580.7296@hs20-bc2-1.build.redhat.com>
[not found] ` <Pine.LNX.4.64.1007021118340.7296@hs20-bc2-1.build.redhat.com>
2010-07-02 17:50 ` [PATCH 3/4] Support discard for multiple devices Mike Snitzer
[not found] ` <Pine.LNX.4.64.1007021119070.7296@hs20-bc2-1.build.redhat.com>
[not found] ` <20100702181430.GD26916@redhat.com>
2010-07-02 19:49 ` [PATCH 4/4] Support discard if at least one underlying device supports it Mikulas Patocka
2010-07-02 20:00 ` Mikulas Patocka
2010-07-02 20:08 ` GFP_KERNEL in ext4 (was: [PATCH 4/4] Support discard if at least one underlying device supports it) Mikulas Patocka
2010-07-06 16:11 ` [PATCH] disallow FS recursion from sb_issue_discard allocation Mike Snitzer
2010-07-27 13:44 ` Ted Ts'o
2010-07-27 15:33 ` Mike Snitzer [this message]
2010-07-28 18:12 ` Jens Axboe
2010-07-28 23:15 ` Ted Ts'o
2010-07-02 20:47 ` [PATCH 4/4] Support discard if at least one underlying device supports it Mike Snitzer
2010-07-02 20:54 ` Alasdair G Kergon
2010-07-05 7:03 ` Dmitry Monakhov
2010-07-05 11:32 ` Mikulas Patocka
2010-07-02 20:29 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100727153352.GA5574@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).