From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] return EINVAL when thawing unfrozen filesystems
Date: Thu, 29 Jul 2010 10:07:31 +0200
Message-ID: <20100729080731.GA29364@lst.de>
References: <4C5080AA.6060206@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
To: Eric Sandeen <sandeen@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:47217 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753796Ab0G2IHo (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 29 Jul 2010 04:07:44 -0400
Content-Disposition: inline
In-Reply-To: <4C5080AA.6060206@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Jul 28, 2010 at 02:10:34PM -0500, Eric Sandeen wrote:
> The iterate_supers() loop in do_thaw_all() assumes
> that we can call thaw_bdev() until we hit an error; when
> I wrote this, we got -EINVAL when requesting a thaw of
> an unfrozen bdev.  (it called until error because we
> may have nested freezes).
> 
> However, commit 4504230a (freeze_bdev: grab active
> reference to frozen superblocks) changed this so that
> we get a return of 0 in this case, and do_thaw_all()
> spins forever when an emergency system-wide thaw
> is requested.
> 
> It looks to me like the change was inadvertent,
> so this patch changes it back.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>