From: Ted Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Phillip Susi <psusi@cfl.rr.com>,
Mike Snitzer <snitzer@redhat.com>,
device-mapper development <dm-devel@redhat.com>,
linux-fsdevel@vger.kernel.org, Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>,
Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH] ext4: fix freeze deadlock under IO
Date: Sun, 1 Aug 2010 17:41:32 -0400 [thread overview]
Message-ID: <20100801214132.GA27573@thunk.org> (raw)
In-Reply-To: <4C226277.4060505@sandeen.net>
On Wed, Jun 23, 2010 at 02:37:27PM -0500, Eric Sandeen wrote:
> Commit 6b0310fbf087ad6 caused a regression resulting in deadlocks
> when freezing a filesystem which had active IO; the vfs_check_frozen
> level (SB_FREEZE_WRITE) did not let the freeze-related IO syncing
> through. Duh.
>
> Changing the test to FREEZE_TRANS should let the normal freeze
> syncing get through the fs, but still block any transactions from
> starting once the fs is completely frozen.
>
> I tested this by running fsstress in the background while periodically
> snapshotting the fs and running fsck on the result. I ran into
> occasional deadlocks, but different ones. I think this is a
> fine fix for the problem at hand, and the other deadlocky things
> will need more investigation.
>
> Reported-by: Phillip Susi <psusi@cfl.rr.com>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Applied to the ext4 patch queue. Sorry for missing this earier.
- Ted
prev parent reply other threads:[~2010-08-01 21:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C1A2839.5010407@cfl.rr.com>
2010-06-17 14:27 ` 2.6.35 causes deadlock when snapshotting root lv Mike Snitzer
2010-06-17 16:16 ` Phillip Susi
2010-06-17 16:27 ` Mike Snitzer
2010-06-18 1:29 ` Phillip Susi
2010-06-18 18:55 ` Eric Sandeen
2010-06-18 19:19 ` Eric Sandeen
2010-06-18 19:23 ` Eric Sandeen
2010-06-23 19:37 ` [PATCH] ext4: fix freeze deadlock under IO Eric Sandeen
2010-08-01 21:41 ` Ted Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100801214132.GA27573@thunk.org \
--to=tytso@mit.edu \
--cc=dchinner@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=psusi@cfl.rr.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).