From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-fsdevel@vger.kernel.org, sandeen@sandeen.net, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] dio: track and serialise unaligned direct IO
Date: Mon, 2 Aug 2010 05:30:24 -0400 [thread overview]
Message-ID: <20100802093024.GA7612@infradead.org> (raw)
In-Reply-To: <1280733945-16231-2-git-send-email-david@fromorbit.com>
> +DEFINE_SPINLOCK(dio_zero_block_lock);
> +LIST_HEAD(dio_zero_block_list);
These two should be static.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2010-08-02 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 7:25 [PATCH 0/2] dio: serialise unaligned direct IO V2 Dave Chinner
2010-08-02 7:25 ` [PATCH 1/2] dio: track and serialise unaligned direct IO Dave Chinner
2010-08-02 9:30 ` Christoph Hellwig [this message]
2010-08-02 18:50 ` Jan Kara
2010-08-02 7:25 ` [PATCH 2/2] dio: scale unaligned IO tracking via multiple lists Dave Chinner
2010-08-02 9:32 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100802093024.GA7612@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).