From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/2] dio: track and serialise unaligned direct IO
Date: Mon, 2 Aug 2010 05:30:24 -0400
Message-ID: <20100802093024.GA7612@infradead.org>
References: <1280733945-16231-1-git-send-email-david@fromorbit.com>
 <1280733945-16231-2-git-send-email-david@fromorbit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, sandeen@sandeen.net, xfs@oss.sgi.com
To: Dave Chinner <david@fromorbit.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:44112 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753095Ab0HBJa0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 2 Aug 2010 05:30:26 -0400
Content-Disposition: inline
In-Reply-To: <1280733945-16231-2-git-send-email-david@fromorbit.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> +DEFINE_SPINLOCK(dio_zero_block_lock);
> +LIST_HEAD(dio_zero_block_list);

These two should be static.

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>