From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
linux-fsdevel@vger.kernel.org, Jens Axboe <jaxboe@fusionio.com>,
hch@infradead.org
Subject: Re: [PATCH 2/3] mm: Fix writeback_in_progress()
Date: Tue, 3 Aug 2010 12:36:10 -0400 [thread overview]
Message-ID: <20100803163610.GB21273@infradead.org> (raw)
In-Reply-To: <1280852440-13630-3-git-send-email-jack@suse.cz>
The patch looks correct to me, but I wonder if we shouldn't try to
get rid of writeback_in_progress instead. There's just two users,
one is the ext4 writeback_if_idle hack, and the other one is
balance_dirty_pages. The latter really should only care about about
other background reclaim beeing pending, and I have no idea why the
former cares - if e.g. any kind of kupdate in the background is pending
which just writes out a few inodes on another fs on the same bdi
it's exiting. The XFS variant of this does unconditional writeback
for all inodes on the sb.
Long term I wonder if we shouldn't get rid of the work list entirely,
and just have a few targets for the flusher thread - we just set a
target and wake it up, and it keeps running until all targets are met.
next prev parent reply other threads:[~2010-08-03 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 16:20 [PATCH 0/3] Small writeback code fixes and improvements Jan Kara
2010-08-03 16:20 ` [PATCH 1/3] mm: Stop background writeback if there is other work queued for the thread Jan Kara
2010-08-03 16:33 ` Christoph Hellwig
2010-08-03 20:41 ` Jan Kara
2010-08-06 12:28 ` Christoph Hellwig
2010-08-03 16:20 ` [PATCH 2/3] mm: Fix writeback_in_progress() Jan Kara
2010-08-03 16:36 ` Christoph Hellwig [this message]
2010-08-03 20:55 ` Jan Kara
2010-08-06 12:34 ` Christoph Hellwig
2010-08-03 16:20 ` [PATCH 3/3] mm: Avoid resetting wb_start after each writeback round Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100803163610.GB21273@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=jaxboe@fusionio.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).