Re: linux-next NFSD: NULL pointer dereference at nfsd_svc()

["J. Bruce Fields" <bfields@fieldses.org>]

On Sat, Aug 07, 2010 at 10:48:02AM +0900, Tetsuo Handa wrote:
> Applying commit 4cd7eb015e92f7cefb43eaab3e111d1b3c7b3cbf (with below patch)
> and commit e844a7b9805a2b74cfd34c8604f5bba3e0869305 and
> commit 7fa53cc872332b265bc5ba1266f39586f218ad4a on linux-2.6.35-next-20100802
> solved all problems found in my environment.
> 
> Thank you.

Thank you for the confirmation.

> --------------------
> 
> Fix build error by commit 4cd7eb015e92f7cefb43eaab3e111d1b3c7b3cbf
> "nfsd: fix startup/shutdown order bug".

Yes, apologies for that--I was compiling as sent that out!

--b.

> 
> ---
>  fs/nfsd/nfssvc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.35-next.orig/fs/nfsd/nfssvc.c
> +++ linux-2.6.35-next/fs/nfsd/nfssvc.c
> @@ -444,7 +444,7 @@ nfsd_svc(unsigned short port, int nrserv
>  	error = nfsd_startup(port, nrservs);
>  	if (error)
>  		goto out_destroy;
> -	}
> +
>  	error = svc_set_num_threads(nfsd_serv, NULL, nrservs);
>  	if (error)
>  		goto out_shutdown;