From: Jan Kara <jack@suse.cz>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2
Date: Thu, 12 Aug 2010 04:46:11 +0200 [thread overview]
Message-ID: <20100812024611.GD14762@quack.suse.cz> (raw)
In-Reply-To: <20100811162435.882687bf.randy.dunlap@oracle.com>
On Wed 11-08-10 16:24:35, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA)
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Steven Whitehouse <swhiteho@redhat.com>
> Cc: cluster-devel@redhat.com
> ---
> fs/quota/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> However, the "depends on" line here seems like overkill to me.
OK, so do you mean that making QUOTACTL default to 'n', removing the
depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select
QUOTACTL would be better?
Honza
>
>
> --- linux-next-20100810.orig/fs/quota/Kconfig
> +++ linux-next-20100810/fs/quota/Kconfig
> @@ -65,7 +65,7 @@ config QFMT_V2
>
> config QUOTACTL
> bool
> - depends on XFS_QUOTA || QUOTA
> + depends on XFS_QUOTA || QUOTA || GFS2_FS
> default y
>
> config QUOTACTL_COMPAT
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2010-08-12 2:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 23:24 [PATCH -next] quota: fix QUOTACTL kconfig for gfs2 Randy Dunlap
2010-08-12 2:46 ` Jan Kara [this message]
2010-08-12 15:39 ` Randy Dunlap
2010-08-12 15:57 ` Steven Whitehouse
2010-08-12 16:03 ` Randy Dunlap
2010-08-12 16:14 ` Christoph Hellwig
2010-08-12 16:34 ` Steven Whitehouse
2010-08-12 16:41 ` Randy Dunlap
2010-08-17 10:22 ` Jan Kara
2010-08-17 15:03 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812024611.GD14762@quack.suse.cz \
--to=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).