From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2
Date: Thu, 12 Aug 2010 12:14:48 -0400
Message-ID: <20100812161448.GA30555@infradead.org>
References: <20100811162435.882687bf.randy.dunlap@oracle.com>
 <20100812024611.GD14762@quack.suse.cz>
 <4C6415C1.9000905@oracle.com>
 <1281628640.2434.41.camel@localhost>
 <4C641B5A.8020300@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Steven Whitehouse <swhiteho@redhat.com>, Jan Kara <jack@suse.cz>,
	linux-fsdevel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from bombadil.infradead.org ([18.85.46.34]:56471 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754466Ab0HLQOy (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 12 Aug 2010 12:14:54 -0400
Content-Disposition: inline
In-Reply-To: <4C641B5A.8020300@oracle.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Aug 12, 2010 at 09:03:38AM -0700, Randy Dunlap wrote:
> > select QUOTA as well, but Christoph removed that. Shouldn't the user
> > interface part of quota be separate from the core implementation?
> 
> Do people use one without the other?

Yes, there's a the quoatctl system call and a few handlers, of which
the current quota implementation is different.  We currently have the
semi-generionc 'dquot' implementation used by extN, reiserfs and ocfs2,
the xfs implementation and the gfs2 implementation.  We also used to
have some stubs in cifs, but they never became an actually useful
implementation.

So selecting QUOTACTL by XFS, GFS2 and QUOTA (which is a bit misnamed)
would be correct.