linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valerie Aurora <vaurora@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Nick Piggin <npiggin@gmail.com>, Jan Kara <jack@suse.cz>,
	Andreas Gruenbacher <agruen@suse.de>
Subject: union mounts via ->get_unlinked_inode()
Date: Tue, 17 Aug 2010 14:12:07 -0400	[thread overview]
Message-ID: <20100817181207.GA5556@shell> (raw)

Hey Miklos,

At the FS workshop, I came up with an idea that will fix the
crash-during-copyup bug and also allow atomic creation of
whiteouts/fallthrus/opaque flags using xattrs, as you proposed.

Instead of ->whiteout() and ->fallthru(), we add just one new file
system op, ->get_unlinked_inode(), which returns an inode that is
allocated but not linked into the namespace - basically, ->create()
followed by ->unlink() without a window in which the partly
initialized file will be visible if the system crashes.  This is
usually already implemented internally by the file system, just not
exported, so it should be minimally invasive.  Then we can copy up
data, set owner, set the whiteout xattr, etc. and when the inode is
consistent, link it into the namespace.  Currently, whiteouts and
fallthrus are implemented with an in-dentry flag so there is no
crash-atomicity problem, but there will be with the xattr-based
version.

So, if the ->get_unlinked_inode() based version works out, I would be
very interested in seeing your whiteout/opaque/fallthru via xattrs
implementation and merging it into my tree.

Thanks,

-VAL

                 reply	other threads:[~2010-08-17 18:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100817181207.GA5556@shell \
    --to=vaurora@redhat.com \
    --cc=agruen@suse.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=npiggin@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).