From: Christoph Hellwig <hch@infradead.org>
To: tj@kernel.org
Cc: chris.mason@oracle.com, swhiteho@redhat.com,
konishi.ryusuke@lab.ntt.co.jp, tytso@mit.edu, jack@suse.cz,
hirofumi@mail.parknet.co.jp, mfasheh@suse.com,
joel.becker@oracle.com, hughd@google.com,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 15/15] remove the BH_Eopnotsupp flag
Date: Wed, 18 Aug 2010 05:29:23 -0400 [thread overview]
Message-ID: <20100818093502.656205471@bombadil.infradead.org> (raw)
In-Reply-To: 20100818093432.646633424@bombadil.infradead.org
[-- Attachment #1: kill-buffer_eopnotsupp --]
[-- Type: text/plain, Size: 2755 bytes --]
This flag was only set for barrier buffers, which we don't submit
anymore.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/buffer.c
===================================================================
--- linux-2.6.orig/fs/buffer.c 2010-08-17 16:54:41.264023137 +0200
+++ linux-2.6/fs/buffer.c 2010-08-17 16:55:20.874006239 +0200
@@ -156,7 +156,7 @@ void end_buffer_write_sync(struct buffer
if (uptodate) {
set_buffer_uptodate(bh);
} else {
- if (!buffer_eopnotsupp(bh) && !quiet_error(bh)) {
+ if (!quiet_error(bh)) {
buffer_io_error(bh);
printk(KERN_WARNING "lost page write due to "
"I/O error on %s\n",
@@ -2998,7 +2998,6 @@ static void end_bio_bh_io_sync(struct bi
if (err == -EOPNOTSUPP) {
set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
- set_bit(BH_Eopnotsupp, &bh->b_state);
}
if (unlikely (test_bit(BIO_QUIET,&bio->bi_flags)))
@@ -3133,10 +3132,6 @@ int __sync_dirty_buffer(struct buffer_he
bh->b_end_io = end_buffer_write_sync;
ret = submit_bh(rw, bh);
wait_on_buffer(bh);
- if (buffer_eopnotsupp(bh)) {
- clear_buffer_eopnotsupp(bh);
- ret = -EOPNOTSUPP;
- }
if (!ret && !buffer_uptodate(bh))
ret = -EIO;
} else {
Index: linux-2.6/fs/fat/misc.c
===================================================================
--- linux-2.6.orig/fs/fat/misc.c 2010-08-17 16:54:15.924259764 +0200
+++ linux-2.6/fs/fat/misc.c 2010-08-17 16:54:31.050283161 +0200
@@ -253,10 +253,7 @@ int fat_sync_bhs(struct buffer_head **bh
ll_rw_block(SWRITE, nr_bhs, bhs);
for (i = 0; i < nr_bhs; i++) {
wait_on_buffer(bhs[i]);
- if (buffer_eopnotsupp(bhs[i])) {
- clear_buffer_eopnotsupp(bhs[i]);
- err = -EOPNOTSUPP;
- } else if (!err && !buffer_uptodate(bhs[i]))
+ if (!err && !buffer_uptodate(bhs[i]))
err = -EIO;
}
return err;
Index: linux-2.6/include/linux/buffer_head.h
===================================================================
--- linux-2.6.orig/include/linux/buffer_head.h 2010-08-17 16:55:24.578254804 +0200
+++ linux-2.6/include/linux/buffer_head.h 2010-08-17 16:55:28.173010427 +0200
@@ -32,7 +32,6 @@ enum bh_state_bits {
BH_Delay, /* Buffer is not yet allocated on disk */
BH_Boundary, /* Block is followed by a discontiguity */
BH_Write_EIO, /* I/O error on write */
- BH_Eopnotsupp, /* DEPRECATED: operation not supported (barrier) */
BH_Unwritten, /* Buffer is allocated on disk but not written */
BH_Quiet, /* Buffer Error Prinks to be quiet */
@@ -124,7 +123,6 @@ BUFFER_FNS(Async_Write, async_write)
BUFFER_FNS(Delay, delay)
BUFFER_FNS(Boundary, boundary)
BUFFER_FNS(Write_EIO, write_io_error)
-BUFFER_FNS(Eopnotsupp, eopnotsupp)
BUFFER_FNS(Unwritten, unwritten)
#define bh_offset(bh) ((unsigned long)(bh)->b_data & ~PAGE_MASK)
next prev parent reply other threads:[~2010-08-18 9:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-18 9:29 [PATCH 00/15] replace barriers with explicit flush / FUA usage Christoph Hellwig
2010-08-18 9:29 ` [PATCH 01/15] kill BH_Ordered flag Christoph Hellwig
2010-08-18 9:29 ` [PATCH 02/15] pass gfp_mask and flags to sb_issue_discard Christoph Hellwig
2010-08-20 1:23 ` Mike Snitzer
2010-08-18 9:29 ` [PATCH 03/15] xfs: replace barriers with explicit flush / FUA usage Christoph Hellwig
2010-08-18 23:47 ` Dave Chinner
2010-08-18 9:29 ` [PATCH 04/15] btrfs: " Christoph Hellwig
2010-08-18 12:06 ` Chris Mason
2010-08-18 9:29 ` [PATCH 05/15] gfs2: " Christoph Hellwig
2010-08-18 10:08 ` Steven Whitehouse
2010-08-18 13:37 ` Bob Peterson
2010-08-18 9:29 ` [PATCH 06/15] reiserfs: " Christoph Hellwig
2010-08-18 13:16 ` Jan Kara
2010-08-18 13:21 ` Chris Mason
2010-08-18 9:29 ` [PATCH 07/15] nilfs2: " Christoph Hellwig
2010-08-18 13:31 ` Ryusuke Konishi
2010-08-18 13:41 ` Christoph Hellwig
2010-08-18 9:29 ` [PATCH 08/15] jbd: " Christoph Hellwig
2010-08-18 13:07 ` Jan Kara
2010-08-18 9:29 ` [PATCH 09/15] jbd2: " Christoph Hellwig
2010-08-18 14:03 ` Jan Kara
2010-08-18 14:09 ` Christoph Hellwig
2010-08-18 9:29 ` [PATCH 10/15] ext4: do not send discards as barriers Christoph Hellwig
2010-08-18 13:28 ` Jan Kara
2010-08-18 9:29 ` [PATCH 11/15] fat: " Christoph Hellwig
2010-08-18 9:29 ` [PATCH 12/15] swap: " Christoph Hellwig
2010-08-19 3:47 ` Hugh Dickins
2010-08-19 4:08 ` Nigel Cunningham
2010-08-19 9:02 ` Christoph Hellwig
2010-08-19 11:35 ` Chris Mason
2010-08-22 12:20 ` Nigel Cunningham
2010-08-18 9:29 ` [PATCH 13/15] remove the WRITE_BARRIER flag Christoph Hellwig
2010-08-18 9:29 ` [PATCH 14/15] remove the BLKDEV_IFL_BARRIER flag Christoph Hellwig
2010-08-20 1:26 ` Mike Snitzer
2010-08-18 9:29 ` Christoph Hellwig [this message]
2010-08-18 10:35 ` [PATCH 00/15] replace barriers with explicit flush / FUA usage Joel Becker
2010-08-18 10:53 ` Christoph Hellwig
2010-08-20 6:50 ` Tao Ma
2010-08-18 15:11 ` Ted Ts'o
2010-08-18 16:46 ` Christoph Hellwig
2010-08-20 4:00 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818093502.656205471@bombadil.infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=joel.becker@oracle.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=swhiteho@redhat.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).