From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: Proposal: Use hi-res clock for file timestamps Date: Wed, 18 Aug 2010 14:54:56 -0400 Message-ID: <20100818185456.GD13050@fieldses.org> References: <87aaolwar8.fsf@basil.nowhere.org> <20100817174134.GA23176@fieldses.org> <20100817182920.GD18161@basil.fritz.box> <20100817190447.GA28049@fieldses.org> <20100817203941.729830b7@lxorguk.ukuu.org.uk> <20100817192937.GD26609@fieldses.org> <20100818155359.66b9ddb6@notabene> <20100818175040.GA6567@basil.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Neil Brown , Alan Cox , "Patrick J. LoPresti" , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel To: Andi Kleen Return-path: Received: from fieldses.org ([174.143.236.118]:48563 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428Ab0HRS5J (ORCPT ); Wed, 18 Aug 2010 14:57:09 -0400 Content-Disposition: inline In-Reply-To: <20100818175040.GA6567@basil.fritz.box> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Aug 18, 2010 at 07:50:40PM +0200, Andi Kleen wrote: > > - nfsd updates it whenever it reads an mtime out of an inode that matches > > current_fs_time to the granularity of 1/HZ. > > That means you have a very very hot cache line on a larger system > if there are a lot of mtime changes. Probably a bad idea. Only if those mtime changes are also followed immediately by nfsd reads of the mtime. That will be the typical case for nfsd writes, though. --b.