From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH 12/15] swap: do not send discards as barriers
Date: Thu, 19 Aug 2010 07:35:45 -0400
Message-ID: <20100819113544.GJ5854@think>
References: <20100818093432.646633424@bombadil.infradead.org>
 <20100818093502.062639046@bombadil.infradead.org>
 <alpine.DEB.1.00.1008182035520.27248@tigran.mtv.corp.google.com>
 <20100819090221.GA29632@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Hugh Dickins <hughd@google.com>, tj@kernel.org,
	swhiteho@redhat.com, konishi.ryusuke@lab.ntt.co.jp, tytso@mit.edu,
	jack@suse.cz, hirofumi@mail.parknet.co.jp, mfasheh@suse.com,
	joel.becker@oracle.com, nigel@tuxonice.net,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from rcsinet10.oracle.com ([148.87.113.121]:32312 "EHLO
	rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751119Ab0HSLge (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 19 Aug 2010 07:36:34 -0400
Content-Disposition: inline
In-Reply-To: <20100819090221.GA29632@infradead.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Aug 19, 2010 at 05:02:21AM -0400, Christoph Hellwig wrote:
> On Wed, Aug 18, 2010 at 08:47:52PM -0700, Hugh Dickins wrote:
> > (though if you happened to respin, I'd be be glad for those newlines
> > between GFP_KERNEL, BLKDEV_IFL_WAIT to go away now)
> > 
> > This patch could go in any time now: I may want to push it in and
> > get it to 35-stable, because it certainly helps against the swap
> > discard regression that Nigel reported (though I've not yet seen
> > his numbers with this).  However, I don't think it eliminates the
> > regression, so I've more testing and experimenting to do before
> > deciding about it - the right answer may just be to disable swap
> > discard, as you asked for long ago.
> 
> If we do get a bit testing I'd be almost inclined to drop BLKDEV_IFL_BARRIER
> under the floor for all callers in .36, and also remove BLKDEV_IFL_WAIT,
> as it's now unconditional.  That would allow us to simpliy the
> synchronous interfaces for the two, and give us an easy way to develop
> a proper asynchronous discard interface in the .37 cycle without
> interfering with the barrier rework.  Any comments on that idea from the
> filesystem crowd?
> 

No complaints here.

-chris