From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, riel@redhat.com, david@fromorbit.com,
hch@lst.de, axboe@kernel.dk, Michael Rubin <mrubin@google.com>,
Jan Kara <jack@suse.cz>, Neil Brown <neilb@suse.de>
Subject: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio
Date: Fri, 20 Aug 2010 11:25:06 +0800 [thread overview]
Message-ID: <20100820032506.GA6662@localhost> (raw)
The dirty_ratio was silently limited to >= 5%. This is not a user
expected behavior. Let's rip it.
It's not likely the user space will depend on the old behavior.
So the risk of breaking user space is very low.
CC: Jan Kara <jack@suse.cz>
CC: Neil Brown <neilb@suse.de>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
mm/page-writeback.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
--- linux-next.orig/mm/page-writeback.c 2010-08-20 10:55:17.000000000 +0800
+++ linux-next/mm/page-writeback.c 2010-08-20 10:56:36.000000000 +0800
@@ -415,14 +415,8 @@ void global_dirty_limits(unsigned long *
if (vm_dirty_bytes)
dirty = DIV_ROUND_UP(vm_dirty_bytes, PAGE_SIZE);
- else {
- int dirty_ratio;
-
- dirty_ratio = vm_dirty_ratio;
- if (dirty_ratio < 5)
- dirty_ratio = 5;
- dirty = (dirty_ratio * available_memory) / 100;
- }
+ else
+ dirty = (vm_dirty_ratio * available_memory) / 100;
if (dirty_background_bytes)
background = DIV_ROUND_UP(dirty_background_bytes, PAGE_SIZE);
next reply other threads:[~2010-08-20 3:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 3:25 Wu Fengguang [this message]
2010-08-20 3:46 ` [PATCH] writeback: remove the internal 5% low bound on dirty_ratio Rik van Riel
2010-08-20 4:13 ` KOSAKI Motohiro
2010-08-20 5:50 ` Con Kolivas
2010-08-20 5:56 ` Wu Fengguang
2010-08-23 4:42 ` Neil Brown
2010-08-23 6:23 ` Wu Fengguang
2010-08-23 6:30 ` Con Kolivas
2010-08-23 7:15 ` Wu Fengguang
2010-08-24 0:00 ` KOSAKI Motohiro
[not found] ` <201008241620.54048.kernel@kolivas.org>
[not found] ` <20100824071440.GA14598@localhost>
[not found] ` <201008251840.00532.kernel@kolivas.org>
2010-08-26 1:29 ` Wu Fengguang
2010-08-26 1:36 ` Neil Brown
2010-08-26 4:22 ` KOSAKI Motohiro
-- strict thread matches above, loose matches on Subject: below --
2010-08-27 10:36 Wu Fengguang
2010-08-27 10:39 ` Peter Zijlstra
2010-08-27 13:47 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820032506.GA6662@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
--cc=neilb@suse.de \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).