From: Wu Fengguang <fengguang.wu@intel.com>
To: Con Kolivas <kernel@kolivas.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"riel@redhat.com" <riel@redhat.com>,
"david@fromorbit.com" <david@fromorbit.com>,
"hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio
Date: Fri, 20 Aug 2010 13:56:21 +0800 [thread overview]
Message-ID: <20100820055621.GA14110@localhost> (raw)
In-Reply-To: <201008201550.54164.kernel@kolivas.org>
On Fri, Aug 20, 2010 at 01:50:54PM +0800, Con Kolivas wrote:
> On Fri, 20 Aug 2010 02:13:25 pm KOSAKI Motohiro wrote:
> > > The dirty_ratio was silently limited to >= 5%. This is not a user
> > > expected behavior. Let's rip it.
> > >
> > > It's not likely the user space will depend on the old behavior.
> > > So the risk of breaking user space is very low.
> > >
> > > CC: Jan Kara <jack@suse.cz>
> > > CC: Neil Brown <neilb@suse.de>
> > > Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> >
> > Thank you.
> > Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
>
> I have tried to do this in the past, and setting this value to 0 on some
> machines caused the machine to come to a complete standstill with small
> writes to disk. It seemed there was some kind of "minimum" amount of data
> required by the VM before anything would make it to the disk and I never
> quite found out where that blockade occurred. This was some time ago (3 years
> ago) so I'm not sure if the problem has since been fixed in the VM since
> then. I suggest you do some testing with this value set to zero before
> approving this change.
Good point. I'll do more homework. Thanks for the reminding!
Thanks,
Fengguang
next prev parent reply other threads:[~2010-08-20 5:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 3:25 [PATCH] writeback: remove the internal 5% low bound on dirty_ratio Wu Fengguang
2010-08-20 3:46 ` Rik van Riel
2010-08-20 4:13 ` KOSAKI Motohiro
2010-08-20 5:50 ` Con Kolivas
2010-08-20 5:56 ` Wu Fengguang [this message]
2010-08-23 4:42 ` Neil Brown
2010-08-23 6:23 ` Wu Fengguang
2010-08-23 6:30 ` Con Kolivas
2010-08-23 7:15 ` Wu Fengguang
2010-08-24 0:00 ` KOSAKI Motohiro
[not found] ` <201008241620.54048.kernel@kolivas.org>
[not found] ` <20100824071440.GA14598@localhost>
[not found] ` <201008251840.00532.kernel@kolivas.org>
2010-08-26 1:29 ` Wu Fengguang
2010-08-26 1:36 ` Neil Brown
2010-08-26 4:22 ` KOSAKI Motohiro
-- strict thread matches above, loose matches on Subject: below --
2010-08-27 10:36 Wu Fengguang
2010-08-27 10:39 ` Peter Zijlstra
2010-08-27 13:47 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100820055621.GA14110@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=kernel@kolivas.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).