linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Michael Rubin <mrubin@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"jack@suse.cz" <jack@suse.cz>,
	"riel@redhat.com" <riel@redhat.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"david@fromorbit.com" <david@fromorbit.com>,
	"npiggin@kernel.dk" <npiggin@kernel.dk>,
	"hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 4/4] writeback: Reporting dirty thresholds in /proc/vmstat
Date: Fri, 20 Aug 2010 18:12:51 +0800	[thread overview]
Message-ID: <20100820101251.GD8440@localhost> (raw)
In-Reply-To: <1282296689-25618-5-git-send-email-mrubin@google.com>

On Fri, Aug 20, 2010 at 05:31:29PM +0800, Michael Rubin wrote:
> The kernel already exposes the user desired thresholds in /proc/sys/vm
> with dirty_background_ratio and background_ratio. But the kernel may
> alter the number requested without giving the user any indication that
> is the case.
> 
> Knowing the actual ratios the kernel is honoring can help app developers
> understand how their buffered IO will be sent to the disk.
> 
> 	$ grep threshold /proc/vmstat
> 	nr_dirty_threshold 409111
> 	nr_dirty_background_threshold 818223
> 
> Signed-off-by: Michael Rubin <mrubin@google.com>
> ---
>  include/linux/mmzone.h |    3 +++
>  mm/vmstat.c            |    5 +++++
>  2 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index fe4e6dd..c2243d0 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -106,6 +106,9 @@ enum zone_stat_item {
>  	NR_SHMEM,		/* shmem pages (included tmpfs/GEM pages) */
>  	NR_FILE_PAGES_DIRTIED,	/* number of times pages get dirtied */
>  	NR_PAGES_ENTERED_WRITEBACK, /* number of times pages enter writeback */
> +	NR_DIRTY_THRESHOLD,	/* writeback threshold */
> +	NR_DIRTY_BG_THRESHOLD,	/* bg writeback threshold */

This may cost cacheline.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-08-20 10:12 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-20  9:31 [PATCH 0/4] writeback: kernel visibility Michael Rubin
2010-08-20  9:31 ` [PATCH 1/4] mm: exporting account_page_dirty Michael Rubin
2010-08-20  9:39   ` Wu Fengguang
2010-08-20 15:37     ` Sage Weil
2010-08-20  9:31 ` [PATCH 2/4] mm: account_page_writeback added Michael Rubin
2010-08-20  9:45   ` Wu Fengguang
2010-08-20 10:08     ` KOSAKI Motohiro
2010-08-20  9:31 ` [PATCH 3/4] writeback: nr_dirtied and nr_entered_writeback in /proc/vmstat Michael Rubin
2010-08-20 10:05   ` KOSAKI Motohiro
2010-08-20 10:08   ` Wu Fengguang
2010-08-20 23:51     ` Michael Rubin
2010-08-21  0:48       ` Wu Fengguang
2010-08-23 17:45         ` Michael Rubin
2010-08-24  2:30           ` Wu Fengguang
2010-08-24  3:02             ` Michael Rubin
2010-08-24  3:25               ` Wu Fengguang
2010-08-20  9:31 ` [PATCH 4/4] writeback: Reporting dirty thresholds " Michael Rubin
2010-08-20 10:06   ` KOSAKI Motohiro
2010-08-22 10:27     ` KOSAKI Motohiro
2010-08-20 10:12   ` Wu Fengguang [this message]
2010-08-21  5:48   ` Wu Fengguang
2010-08-23 17:52     ` Michael Rubin
2010-08-24  1:20       ` KOSAKI Motohiro
2010-08-24  1:41         ` Michael Rubin
2010-08-24  2:11           ` Wu Fengguang
2010-08-24  2:42             ` Michael Rubin
2010-08-24  2:01   ` Wu Fengguang
2010-08-24  2:04     ` Michael Rubin
  -- strict thread matches above, loose matches on Subject: below --
2010-08-28  2:40 [PATCH 0/4] writeback: kernel visibility Michael Rubin
2010-08-28  2:40 ` [PATCH 4/4] writeback: Reporting dirty thresholds in /proc/vmstat Michael Rubin
2010-08-30  0:28   ` KOSAKI Motohiro
2010-08-30 16:25     ` Michael Rubin
2010-08-31  1:07       ` KOSAKI Motohiro
2010-08-31  1:32         ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100820101251.GD8440@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mrubin@google.com \
    --cc=npiggin@kernel.dk \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).