From: Christoph Hellwig <hch@infradead.org>
To: Marco Stornelli <marco.stornelli@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: get_inode callback of generic_fh_to_{dentry|parent}
Date: Mon, 23 Aug 2010 10:10:09 -0400 [thread overview]
Message-ID: <20100823141009.GA25185@infradead.org> (raw)
In-Reply-To: <AANLkTimD4jaSOq=si=CbCZtSZU1caY=zNfPuNiiHgVwV@mail.gmail.com>
On Mon, Aug 23, 2010 at 03:32:04PM +0200, Marco Stornelli wrote:
> Hi,
>
> I'm the maintainer of pramfs. I'm currently working in the export
> operation for my fs and I've got a question about the callback in the
> subject. Is it right that this function return an error for a not
> allocated inode? I see a comment for example in the ext2 code for the
> callback like this:
>
> /* iget isn't really right if the inode is currently unallocated!! */
>
> So I think it's cleaner to use ilookup() instead of iget(). Comments?
ilookup only returns an inode if it's already in the inode cache.
the get_inode callback needs to return an inode if it's allocated, even
if it's not in the inode cache.
next prev parent reply other threads:[~2010-08-23 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-23 13:32 get_inode callback of generic_fh_to_{dentry|parent} Marco Stornelli
2010-08-23 14:10 ` Christoph Hellwig [this message]
2010-08-24 6:46 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100823141009.GA25185@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).