From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCHSET block#for-2.6.36-post] block: replace barrier with sequenced flush Date: Mon, 23 Aug 2010 16:19:35 +0200 Message-ID: <20100823141935.GA23963@lst.de> References: <1281616891-5691-1-git-send-email-tj@kernel.org> <20100820132214.GA6184@lst.de> <4C6E9CAF.5010202@redhat.com> <4C7269E9.9070304@kernel.org> <20100823124815.GA20095@lst.de> <4C727E96.5020801@redhat.com> <4C727F2B.6060501@fusionio.com> <20100823140823.GA23490@lst.de> <4C728210.6040605@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Jens Axboe , Ric Wheeler , "linux-fsdevel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-ide@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "James.Bottomley@suse.de" , "tytso@mit.edu" , "chris.mason@oracle.com" , "swhiteho@redhat.com" , "konishi.ryusuke@lab.ntt.co.jp" , "dm-devel@redhat.com" , "vst@vlnb.net" , "jack@suse.cz" , "hare@suse.de" To: Tejun Heo Return-path: Content-Disposition: inline In-Reply-To: <4C728210.6040605@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Aug 23, 2010 at 04:13:36PM +0200, Tejun Heo wrote: > Yeah, that sounds reasonable. blk_queue_flush() can be called anytime > without locking anyway, so it should be really easy to implement too. I don't think we can simply call blk_queue_flush - we must ensure to never set more bits than the device allows. We'll just need two sets of flags in the request queue, with the sysfs file checking that it never allows more flags than blk_queue_flush. I'll prepare a patch for this on top of the current series.