From: Wu Fengguang <fengguang.wu@intel.com>
To: Michael Rubin <mrubin@google.com>
Cc: Shailabh Nagar <nagar@watson.ibm.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"jack@suse.cz" <jack@suse.cz>,
"riel@redhat.com" <riel@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"david@fromorbit.com" <david@fromorbit.com>,
"npiggin@kernel.dk" <npiggin@kernel.dk>,
"hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>
Subject: Re: [PATCH 3/4] writeback: nr_dirtied and nr_entered_writeback in /proc/vmstat
Date: Tue, 24 Aug 2010 11:25:34 +0800 [thread overview]
Message-ID: <20100824032534.GC11970@localhost> (raw)
In-Reply-To: <AANLkTi=KwJat47-7GjQOhhMnriiBE5sBOR2b9b7XC6As@mail.gmail.com>
On Tue, Aug 24, 2010 at 11:02:42AM +0800, Michael Rubin wrote:
> On Mon, Aug 23, 2010 at 7:30 PM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> > It's about the interface, I don't mind you adding the per-node vmstat
> > entries which may be convenient for you and mostly harmless to others.
> >
> > My concern is, what do you think about the existing
> > /proc/<pid>/io:write_bytes interface and is it good enough for your?
> > You'll have to iterate through tasks to collect numbers for one job or
> > for the whole system, however that should be easy and more flexible?
>
> Is this as an alternative to the vmstat counters or the per node
> vmstat counters?
>
> In either case I am not sure /proc/pid will be sufficient. What if 20
> processes are created, write a lot of data, then quit? How do we know
> about those events later? What about jobs that wake up, write data
> then quit quickly?
According to Documentation/accounting/taskstats.txt, it's possible to
register a task for collecting its stat numbers when it quits. However
I'm not sure if there are reliable ways to do this if tasks come and
go very quickly. It may help to somehow automatically add the numbers
to the parent process at process quit time.
> If we are running many many tasks I would think the amount of time it
> can take to cycle through all of them might mean we might not capture
> all the data.
Yes, 10k tasks may be too much to track.
> The goal is to have a complete view of the dirtying and cleaning of
> the pages over time. Using /proc/pid feels like it won't achieve that.
Looks so.
Thanks,
Fengguang
next prev parent reply other threads:[~2010-08-24 3:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-20 9:31 [PATCH 0/4] writeback: kernel visibility Michael Rubin
2010-08-20 9:31 ` [PATCH 1/4] mm: exporting account_page_dirty Michael Rubin
2010-08-20 9:39 ` Wu Fengguang
2010-08-20 15:37 ` Sage Weil
2010-08-20 9:31 ` [PATCH 2/4] mm: account_page_writeback added Michael Rubin
2010-08-20 9:45 ` Wu Fengguang
2010-08-20 10:08 ` KOSAKI Motohiro
2010-08-20 9:31 ` [PATCH 3/4] writeback: nr_dirtied and nr_entered_writeback in /proc/vmstat Michael Rubin
2010-08-20 10:05 ` KOSAKI Motohiro
2010-08-20 10:08 ` Wu Fengguang
2010-08-20 23:51 ` Michael Rubin
2010-08-21 0:48 ` Wu Fengguang
2010-08-23 17:45 ` Michael Rubin
2010-08-24 2:30 ` Wu Fengguang
2010-08-24 3:02 ` Michael Rubin
2010-08-24 3:25 ` Wu Fengguang [this message]
2010-08-20 9:31 ` [PATCH 4/4] writeback: Reporting dirty thresholds " Michael Rubin
2010-08-20 10:06 ` KOSAKI Motohiro
2010-08-22 10:27 ` KOSAKI Motohiro
2010-08-20 10:12 ` Wu Fengguang
2010-08-21 5:48 ` Wu Fengguang
2010-08-23 17:52 ` Michael Rubin
2010-08-24 1:20 ` KOSAKI Motohiro
2010-08-24 1:41 ` Michael Rubin
2010-08-24 2:11 ` Wu Fengguang
2010-08-24 2:42 ` Michael Rubin
2010-08-24 2:01 ` Wu Fengguang
2010-08-24 2:04 ` Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824032534.GC11970@localhost \
--to=fengguang.wu@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mrubin@google.com \
--cc=nagar@watson.ibm.com \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).