From mboxrd@z Thu Jan 1 00:00:00 1970 From: KOSAKI Motohiro Subject: Re: [PATCH] writeback: remove the internal 5% low bound on dirty_ratio Date: Thu, 26 Aug 2010 13:22:02 +0900 (JST) Message-ID: <20100826132046.F670.A69D9226@jp.fujitsu.com> References: <20100826012945.GA7859@localhost> <20100826113649.687b453a@notabene> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: kosaki.motohiro@jp.fujitsu.com, Wu Fengguang , Con Kolivas , Jan Kara , Rik van Riel , Peter Zijlstra , Andrew Morton , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "david@fromorbit.com" , "hch@lst.de" , "axboe@kernel.dk" To: Neil Brown Return-path: In-Reply-To: <20100826113649.687b453a@notabene> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org > > writeback: remove the internal 5% low bound on dirty_ratio > > > > The dirty_ratio was silently limited in global_dirty_limits() to >= 5%. > > This is not a user expected behavior. And it's inconsistent with > > calc_period_shift(), which uses the plain vm_dirty_ratio value. > > > > Let's rip the internal bound. > > > > At the same time, fix balance_dirty_pages() to work with the > > dirty_thresh=0 case. This allows applications to proceed when > > dirty+writeback pages are all cleaned. > > And ">" fits with the name "exceeded" better than ">=" does. I think it is > an aesthetic improvement as well as a functional one. > > Reviewed-by: NeilBrown I agree :) Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org