linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Shawn Bohrer <shawn.bohrer@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	Davide Libenzi <davidel@xmailserver.org>
Subject: Re: [PATCH] hrtimer: make epoll_wait() use the hrtimer range feature
Date: Thu, 26 Aug 2010 15:31:56 -0700	[thread overview]
Message-ID: <20100826153156.9ca92942.akpm@linux-foundation.org> (raw)
In-Reply-To: <1281307532-3235-1-git-send-email-shawn.bohrer@gmail.com>


I'd say this is an epoll patch, not an hrtimer patch.  So I renamed it
to "epoll: make epoll_wait() use the hrtimer range feature".

Davide looks after epoll, so let's cc him.

On Sun,  8 Aug 2010 17:45:32 -0500
Shawn Bohrer <shawn.bohrer@gmail.com> wrote:

> This make epoll use hrtimers for the timeout value which prevents
> epoll_wait() from timing out up to a millisecond early.
> 
> This mirrors the behavior of select() and poll().
> 
> ...
>
> --- a/fs/eventpoll.c
> +++ b/fs/eventpoll.c

Davide stuff ;)

> --- a/fs/select.c
> +++ b/fs/select.c
> @@ -67,7 +67,7 @@ static long __estimate_accuracy(struct timespec *tv)
>  	return slack;
>  }
>  
> -static long estimate_accuracy(struct timespec *tv)
> +long estimate_accuracy(struct timespec *tv)

"estimate_accuracy" is a rotten name for a global symbol.  I queued a
preparatory patch which renames this to "select_estimate_accuracy".

  reply	other threads:[~2010-08-26 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-08 22:45 [PATCH] hrtimer: make epoll_wait() use the hrtimer range feature Shawn Bohrer
2010-08-26 22:31 ` Andrew Morton [this message]
2010-08-26 22:45 ` Davide Libenzi
2010-08-26 23:02   ` Thomas Gleixner
2010-08-26 23:23     ` Davide Libenzi
2010-11-24  8:33 ` Mike Frysinger
2010-11-24 14:52   ` Shawn Bohrer
2010-11-24 20:57     ` Mike Frysinger
2010-11-25  3:31       ` [PATCH] epoll: initialize slack for negative timeout values Shawn Bohrer
2010-11-27 18:58         ` Davide Libenzi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100826153156.9ca92942.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davidel@xmailserver.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.bohrer@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).