From: Neil Brown <neilb@suse.de>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
vaurora@redhat.com, viro@zeniv.linux.org.uk, jblunck@suse.de,
hch@infradead.org
Subject: Re: [PATCH 2/5] vfs: make i_op->permission take a dentry instead of an inode
Date: Fri, 27 Aug 2010 14:11:00 +1000 [thread overview]
Message-ID: <20100827141100.45feae88@notabene> (raw)
In-Reply-To: <1282854242.16993.6.camel@moss-terrapins.epoch.ncsc.mil>
On Thu, 26 Aug 2010 16:24:02 -0400
"David P. Quigley" <dpquigl@tycho.nsa.gov> wrote:
> I may be missing something but I looked at your patch series and I see
> no good reason for this patch at all. You just churned a lot of code for
> something that you don't even have a need for in the patch set. Your
> only two new callers of this function could just as easily have used the
> inode since it isn't doing anything special with the dentry. It actually
> pulls the inode out of it and uses it in generic_permission and
> security_inode_permission. If you are going to change this you should
> also change generic_permission as well. Honestly I'd rather see the
> dentry requirement removed from inode operations instead but
> unfortunately this isn't possible as I found out with my attempts to
> remove the dentry requirement for get/setxattr
union_permission needs the dentry to get access to d_fsdata, which caches the
upperpath and lowerpath which were found at lookup time.
Is that what you missed?
NeilBrown
next prev parent reply other threads:[~2010-08-27 4:11 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 18:33 [PATCH 0/5] hybrid union filesystem prototype Miklos Szeredi
2010-08-26 18:33 ` [PATCH 1/5] vfs: implement open "forwarding" Miklos Szeredi
2010-08-26 18:33 ` [PATCH 2/5] vfs: make i_op->permission take a dentry instead of an inode Miklos Szeredi
2010-08-26 20:24 ` David P. Quigley
2010-08-27 4:11 ` Neil Brown [this message]
2010-08-27 18:13 ` David P. Quigley
2010-08-27 19:21 ` Valerie Aurora
2010-08-27 18:31 ` David P. Quigley
2010-08-26 18:33 ` [PATCH 3/5] vfs: add flag to allow rename to same inode Miklos Szeredi
2010-08-26 18:33 ` [PATCH 4/5] vfs: export do_splice_direct() to modules Miklos Szeredi
2010-08-26 18:33 ` [PATCH 5/5] union: hybrid union filesystem prototype Miklos Szeredi
2010-09-01 21:42 ` Valerie Aurora
2010-09-02 9:19 ` Miklos Szeredi
2010-09-02 21:33 ` Valerie Aurora
2010-09-03 5:10 ` Neil Brown
2010-09-03 9:16 ` Miklos Szeredi
2010-09-09 16:02 ` David P. Quigley
2010-09-03 8:52 ` Miklos Szeredi
2010-09-02 21:42 ` Valerie Aurora
2010-09-03 12:31 ` Miklos Szeredi
2010-08-27 7:05 ` [PATCH 0/5] " Neil Brown
2010-08-27 8:47 ` Miklos Szeredi
2010-08-27 11:35 ` Neil Brown
2010-08-27 16:53 ` Miklos Szeredi
2010-08-29 4:42 ` Neil Brown
2010-08-30 10:18 ` Miklos Szeredi
2010-08-30 11:40 ` Neil Brown
2010-08-30 12:20 ` Miklos Szeredi
2010-08-31 19:18 ` Valerie Aurora
2010-08-31 20:19 ` Trond Myklebust
2010-09-01 1:56 ` Valerie Aurora
2010-09-01 4:04 ` Trond Myklebust
2010-09-01 4:33 ` Neil Brown
2010-09-01 20:11 ` Miklos Szeredi
2010-08-31 19:29 ` Valerie Aurora
2010-09-02 13:15 ` Jan Engelhardt
2010-09-02 13:32 ` Neil Brown
2010-09-02 14:25 ` Jan Engelhardt
2010-09-02 14:28 ` Miklos Szeredi
2010-09-08 19:47 ` David P. Quigley
2010-09-23 13:18 ` Jan Engelhardt
2010-09-23 19:22 ` Valerie Aurora
2010-08-30 18:38 ` Valerie Aurora
2010-08-30 23:12 ` Neil Brown
2010-08-31 11:00 ` Miklos Szeredi
2010-08-31 11:24 ` Neil Brown
2010-08-31 15:05 ` Kyle Moffett
2010-08-31 20:36 ` Valerie Aurora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100827141100.45feae88@notabene \
--to=neilb@suse.de \
--cc=dpquigl@tycho.nsa.gov \
--cc=hch@infradead.org \
--cc=jblunck@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).