From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 0/3] BDI handling fixes Date: Thu, 16 Sep 2010 19:47:42 -0400 Message-ID: <20100916234742.GA26030@infradead.org> References: <1284677051-28564-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jens@suse.cz, "Axboe , LKML , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <1284677051-28564-1-git-send-email-jack@suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Sep 17, 2010 at 12:44:08AM +0200, Jan Kara wrote: > > Hi, > > series of these three patches fixes the warning in __mark_inode_dirty() > which happens when I do e.g. touch /dev/zero. The first two patches should > be obvious enough and probably worth merging independently of the third > patch. The third patch is upto a discussion whether we want to solve the > problem that way or differently. Christoph, I know we spoke at LSF that > inode_to_bdi() could be a per-sb method but the current version of the > patch seems clean enough to me that we could maybe go even without the > special callback? Feel free to go with the simpler one. But what I think really needs to be changes is the no writeback flag - it's exactly the wrong way around. Instead just add a flag to allow writeback for the block device and fs-specific bdi structures.