From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: Remaining BKL users, what to do Date: Fri, 17 Sep 2010 10:02:19 -0400 Message-ID: <20100917140219.GA9454@infradead.org> References: <201009161632.59210.arnd@arndb.de> <201009171245.41930.arnd@arndb.de> <20100917133231.GA9411@infradead.org> <201009171550.49282.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Anton Altaparmakov , Jan Kara , codalist@coda.cs.cmu.edu, autofs@linux.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Mikulas Patocka , Trond Myklebust , Petr Vandrovec , Anders Larsen , Evgeniy Dushistov , Ingo Molnar , netdev@vger.kernel.org, Samuel Ortiz , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Andrew Hendry To: Arnd Bergmann Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:37645 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751124Ab0IQOC1 (ORCPT ); Fri, 17 Sep 2010 10:02:27 -0400 Content-Disposition: inline In-Reply-To: <201009171550.49282.arnd@arndb.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 17, 2010 at 03:50:49PM +0200, Arnd Bergmann wrote: > On Friday 17 September 2010, Christoph Hellwig wrote: > > > > On Fri, Sep 17, 2010 at 12:45:41PM +0200, Arnd Bergmann wrote: > > > ncpfs: replace BKL with lock_super > > > > Err, no. lock_super is just as much on it's way out as the BKL. We've > > managed to move it down from the VFS into a few remaining filesystems > > and now need to get rid of those users. Please don't add any new ones. > > Ok. I guess that's also a NAK for my the isofs patch I posted yesterday > then. Do you have any suggestions for an alternative approach? Just add a per-sb mutex inside the filesystem. Given that lock_super isn't used by the VFS anymore that's actually equivalent.