From: Neil Brown <neilb@suse.de>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
vaurora@redhat.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/7 v3] overlay filesystem prototype
Date: Tue, 21 Sep 2010 11:31:01 +1000 [thread overview]
Message-ID: <20100921113101.3bde59bd@notabene> (raw)
In-Reply-To: <20100920180404.939991832@szeredi.hu>
On Mon, 20 Sep 2010 20:04:04 +0200
Miklos Szeredi <miklos@szeredi.hu> wrote:
> Here's an updated patch series.
>
> For now I reverted Neil's revalidation patch. Not requiring strict
> read-only would make sense for just trying it out and experimenting.
> But for real uses, I'm not sure...
:-)
I think you significantly reduce the value by insisting on read-only but as
this is purely a theoretical perspective at the moment (I have no concrete
use-case) I won't push it.
I had another patch I was working on which caused overlayfs to keep negative
dentries in upperdentry or lowerdentry rather than just setting them to
NULL. This would allow revalidation to notice objects appearing in the
underlying filesystem. I guess you won't want that now .... I think it made
some of the code a bit neater, but I never finished it so I cannot be sure of
the overall effect.
I'm curious as to why upperdentry is now called __upperdentry - it isn't
clear from a quick reading..
Thanks,
NeilBrown
next prev parent reply other threads:[~2010-09-21 1:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-20 18:04 [PATCH 0/7 v3] overlay filesystem prototype Miklos Szeredi
2010-09-20 18:04 ` [PATCH 1/7 v3] vfs: implement open "forwarding" Miklos Szeredi
2010-09-20 18:04 ` [PATCH 2/7 v3] vfs: make i_op->permission take a dentry instead of an inode Miklos Szeredi
2010-09-20 18:04 ` [PATCH 3/7 v3] vfs: add flag to allow rename to same inode Miklos Szeredi
2010-09-23 22:04 ` Valerie Aurora
2010-09-20 18:04 ` [PATCH 4/7 v3] vfs: export do_splice_direct() to modules Miklos Szeredi
2010-09-20 18:04 ` [PATCH 5/7 v3] vfs: fix possible use after free in finish_open() Miklos Szeredi
2010-09-23 20:19 ` Valerie Aurora
2010-09-20 18:04 ` [PATCH 6/7 v3] overlay: hybrid overlay filesystem prototype Miklos Szeredi
2010-09-22 23:21 ` Valerie Aurora
2010-09-24 14:33 ` Jens Axboe
2010-09-24 17:16 ` Valerie Aurora
2010-09-24 17:56 ` Valerie Aurora
2010-09-27 8:11 ` Miklos Szeredi
2010-09-27 11:49 ` Andreas Gruenbacher
2010-09-27 12:15 ` J. R. Okajima
2010-09-27 18:47 ` Valerie Aurora
2010-09-28 8:24 ` Andreas Gruenbacher
2010-09-30 21:51 ` Valerie Aurora
2010-10-01 9:34 ` Andreas Gruenbacher
2010-10-06 17:31 ` Valerie Aurora
2010-10-11 9:41 ` Michal Suchanek
2010-10-11 13:51 ` Scott James Remnant
2010-09-20 18:04 ` [PATCH 7/7 v3] overlay: overlay filesystem documentation Miklos Szeredi
2010-09-21 1:31 ` Neil Brown [this message]
2010-09-22 9:50 ` [PATCH 0/7 v3] overlay filesystem prototype Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921113101.3bde59bd@notabene \
--to=neilb@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).