From mboxrd@z Thu Jan  1 00:00:00 1970
From: Valerie Aurora <vaurora@redhat.com>
Subject: Re: [PATCH 6/7 v3] overlay: hybrid overlay filesystem prototype
Date: Wed, 22 Sep 2010 19:21:11 -0400
Message-ID: <20100922232110.GC26268@shell>
References: <20100920180404.939991832@szeredi.hu> <20100920180447.854260354@szeredi.hu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	neilb@suse.de, viro@zeniv.linux.org.uk
To: Miklos Szeredi <miklos@szeredi.hu>, Jens Axboe <axboe@kernel.dk>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:10739 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750819Ab0IVXVb (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 22 Sep 2010 19:21:31 -0400
Content-Disposition: inline
In-Reply-To: <20100920180447.854260354@szeredi.hu>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Sep 20, 2010 at 08:04:10PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> This overlay filesystem is a hybrid of entirely filesystem based
> (unionfs, aufs) and entierly VFS based (union mounts) solutions.

[...]

> +static int ovl_copy_up_data(struct path *old, struct path *new, loff_t len)
> +{
> +	struct file *old_file;
> +	struct file *new_file;
> +	int error = 0;
> +
> +	if (len == 0)
> +		return 0;
> +
> +	old_file = path_open(old, O_RDONLY);
> +	if (IS_ERR(old_file))
> +		return PTR_ERR(old_file);
> +
> +	new_file = path_open(new, O_WRONLY);
> +	if (IS_ERR(new_file)) {
> +		error = PTR_ERR(new_file);
> +		goto out_fput;
> +	}
> +
> +	/* FIXME: copy up sparse files efficiently */
> +	while (len) {
> +		loff_t offset = new_file->f_pos;
> +		size_t this_len = OVL_COPY_UP_CHUNK_SIZE;
> +		long bytes;
> +
> +		if (len < this_len)
> +			this_len = len;
> +
> +		if (signal_pending_state(TASK_KILLABLE, current))
> +			return -EINTR;
> +
> +		bytes = do_splice_direct(old_file, &offset, new_file, this_len,
> +				 SPLICE_F_MOVE);

Interruptible copyup is good.  But it looks like splice setup is kind
of heavyweight and we should do it as seldom as possible.

What about implementing splice flag SPLICE_F_INTERRUPTIBLE instead?

-VAL