From: Matt Helsley <matthltc@us.ibm.com>
To: Brad Boyer <flar@allandria.com>
Cc: Matt Helsley <matthltc@us.ibm.com>,
containers@lists.linux-foundation.org,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 2/6] [RFC] Create the .relink file_operation
Date: Mon, 27 Sep 2010 12:16:28 -0700 [thread overview]
Message-ID: <20100927191628.GN23839@count0.beaverton.ibm.com> (raw)
In-Reply-To: <20100926190837.GA9308@cynthia.pants.nu>
On Sun, Sep 26, 2010 at 12:08:37PM -0700, Brad Boyer wrote:
> On Thu, Sep 23, 2010 at 02:53:28PM -0700, Matt Helsley wrote:
> > Not all filesystems will necessarily be able to support relinking an
> > orphan inode back into the filesystem. Some offlist feedback suggested
> > that instead of overloading .link that relinking should be a separate
> > file operation for this reason.
> >
> > Since .relink is a superset of .link make the VFS call .relink where
> > possible and .link otherwise.
> >
> > The next commit will change ext3/4 to enable this operation.
>
> I may have missed something in one of these patches (patch 1 and any
> original summary if there was one don't appear in my email), but
> what is the point of the new operation? I didn't see any case that
> treats one any different than the other. What is disallowed (and how)
> for a driver which does not implement .relink but has .link?
Did you get patch 3? It shows how ext3/ext4 add the ability to take an
inode that has been unlinked, placed onto the orphan list, and relink it.
Cheers,
-Matt Helsley
next prev parent reply other threads:[~2010-09-27 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1285278812-16972-1-git-send-email-matthltc@us.ibm.com>
[not found] ` <6987185123220ec2034677299859c5a63eaf2aed.1285278339.git.matthltc@us.ibm.com>
2010-09-23 21:53 ` [PATCH 2/6] [RFC] Create the .relink file_operation Matt Helsley
2010-09-23 21:53 ` [PATCH 3/6] [RFC] ext3/4: Allow relinking to unlinked files Matt Helsley
2010-09-23 21:53 ` [PATCH 4/6] [RFC] Split do_linkat() out of sys_linkat Matt Helsley
2010-09-23 21:53 ` [PATCH 5/6] [RFC] Checkpoint/restart unlinked files Matt Helsley
2010-09-29 22:22 ` Oren Laadan
2010-09-30 1:17 ` Matt Helsley
2010-09-30 15:45 ` Oren Laadan
2010-10-22 23:43 ` Sukadev Bhattiprolu
[not found] ` <9eade1f1ec10c23dae296feda8af9fe87085e843.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-29 20:28 ` [PATCH 4/6] [RFC] Split do_linkat() out of sys_linkat Oren Laadan
[not found] ` <d91e3660266d3a2956c4d1aebc9cb618081b21ef.1285278339.git.matthltc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-09-26 19:08 ` [PATCH 2/6] [RFC] Create the .relink file_operation Brad Boyer
2010-09-27 19:16 ` Matt Helsley [this message]
2010-09-27 22:03 ` Brad Boyer
2010-09-29 20:16 ` Oren Laadan
2010-09-29 20:19 ` Oren Laadan
2010-09-29 23:07 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927191628.GN23839@count0.beaverton.ibm.com \
--to=matthltc@us.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=containers@lists.linux-foundation.org \
--cc=flar@allandria.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).