From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 05/17] fs: icache lock i_count
Date: Wed, 29 Sep 2010 21:52:29 -0700
Message-ID: <20100929215229.160c7bce.akpm@linux-foundation.org>
References: <1285762729-17928-1-git-send-email-david@fromorbit.com>
	<1285762729-17928-6-git-send-email-david@fromorbit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Dave Chinner <david@fromorbit.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1285762729-17928-6-git-send-email-david@fromorbit.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 29 Sep 2010 22:18:37 +1000 Dave Chinner <david@fromorbit.com> wrote:

> -	if (atomic_read(&inode->i_count) != 1)
> +	if (inode->i_count != 1)

This really should have been renamed to catch unconverted code.

Such code usually wouldn't compile anyway, but it will if it takes the
address of i_count only (for example).

And maybe we should access this guy via accessor functions, dunno.