From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] cifs: set backing_dev_info on new S_ISREG inodes
Date: Wed, 29 Sep 2010 19:17:30 -0400 [thread overview]
Message-ID: <20100929231730.GA6921@infradead.org> (raw)
In-Reply-To: <1285768194-29595-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Wed, Sep 29, 2010 at 09:49:54AM -0400, Jeff Layton wrote:
> Testing on very recent kernel (2.6.36-rc6) made this warning pop:
>
> WARNING: at fs/fs-writeback.c:87 inode_to_bdi+0x65/0x70()
> Hardware name:
> Dirtiable inode bdi default != sb bdi cifs
>
> ...the following patch fixes it and seems to be the obviously correct
> thing to do for cifs.
See my patch in the btrfs/default_backing_dev_info thread for the real
fix for the underlying issue. But your patch won't harm either way.
next prev parent reply other threads:[~2010-09-29 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 13:49 [PATCH] cifs: set backing_dev_info on new S_ISREG inodes Jeff Layton
[not found] ` <1285768194-29595-1-git-send-email-jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-09-29 23:17 ` Christoph Hellwig [this message]
[not found] ` <20100929231730.GA6921-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2010-09-30 11:26 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929231730.GA6921@infradead.org \
--to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).