linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Valerie Aurora <vaurora@redhat.com>
To: Andreas Gruenbacher <agruen@suse.de>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	linuxram@us.ibm.com, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, neilb@suse.de,
	viro@zeniv.linux.org.uk
Subject: Re: [PATCH 6/7 v3] overlay: hybrid overlay filesystem prototype
Date: Thu, 30 Sep 2010 17:51:15 -0400	[thread overview]
Message-ID: <20100930215114.GD490@shell> (raw)
In-Reply-To: <201009281025.00727.agruen@suse.de>

On Tue, Sep 28, 2010 at 10:24:59AM +0200, Andreas Gruenbacher wrote:
> On Monday 27 September 2010 20:47:47 Valerie Aurora wrote:
> > Maybe I don't understand.  It seems like directories created when the
> > file system is *not* union mounted should definitely be merged with
> > matching directories on the lower layer.
> >
> > Take the case of /etc/fstab.  The first union mount never touches /etc
> > and it doesn't exist on the topmost layer.  Then we unmount the upper
> > layer, mount it somewhere else as a plain mount, and create /etc/ and
> > /etc/fstab.  When we union mount it back over the lower layer again,
> > we still want the lower layer /etc/ to be merged with the topmost
> > /etc/, or else init.d will disappear.
> 
> I can't think of a reason why the upper layer would really *need* to be 
> modified separately as in this example though, and I'm sure that examples for 
> opaqueness by default can be constructed as well.  Transparency comes at a 
> cost though (lookup, readdir, whiteouts), and defaulting to opaque directories 
> will be more efficient in some cases.  This is why I think that opaqueness by 
> default is preferable.

I agree with that for directories created while it is union mounted.

> > Again, maybe I'm misunderstanding, but this doesn't make much sense to
> > me.  Say I create:
> > 
> > /upper/a_dir/upper_file
> > /lower/a_dir/lower_file
> > 
> > Then when I union mount them, I want a_dir/ to be transparent
> > automatically and show both upper_file and lower_file, without marking
> > it manually.
> 
> Why?

Hm, this was a pretty basic assumption for me - that you'd want to
construct a topmost image offline that would be "merged" with the
lower layers.  So, for example:

Topmost layer contains:

/etc/hostname

Lower layers contain everything else in /etc/.  So /etc/ would exist
on the topmost layer at the time of union mount, but we would want it
to be transparent.  But if we created a new dir *during* the union
mount, it would be opaque.

What was your model?

-VAL

  reply	other threads:[~2010-09-30 21:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20 18:04 [PATCH 0/7 v3] overlay filesystem prototype Miklos Szeredi
2010-09-20 18:04 ` [PATCH 1/7 v3] vfs: implement open "forwarding" Miklos Szeredi
2010-09-20 18:04 ` [PATCH 2/7 v3] vfs: make i_op->permission take a dentry instead of an inode Miklos Szeredi
2010-09-20 18:04 ` [PATCH 3/7 v3] vfs: add flag to allow rename to same inode Miklos Szeredi
2010-09-23 22:04   ` Valerie Aurora
2010-09-20 18:04 ` [PATCH 4/7 v3] vfs: export do_splice_direct() to modules Miklos Szeredi
2010-09-20 18:04 ` [PATCH 5/7 v3] vfs: fix possible use after free in finish_open() Miklos Szeredi
2010-09-23 20:19   ` Valerie Aurora
2010-09-20 18:04 ` [PATCH 6/7 v3] overlay: hybrid overlay filesystem prototype Miklos Szeredi
2010-09-22 23:21   ` Valerie Aurora
2010-09-24 14:33     ` Jens Axboe
2010-09-24 17:16       ` Valerie Aurora
2010-09-24 17:56   ` Valerie Aurora
2010-09-27  8:11     ` Miklos Szeredi
2010-09-27 11:49       ` Andreas Gruenbacher
2010-09-27 12:15         ` J. R. Okajima
2010-09-27 18:47       ` Valerie Aurora
2010-09-28  8:24         ` Andreas Gruenbacher
2010-09-30 21:51           ` Valerie Aurora [this message]
2010-10-01  9:34             ` Andreas Gruenbacher
2010-10-06 17:31               ` Valerie Aurora
2010-10-11  9:41                 ` Michal Suchanek
2010-10-11 13:51                 ` Scott James Remnant
2010-09-20 18:04 ` [PATCH 7/7 v3] overlay: overlay filesystem documentation Miklos Szeredi
2010-09-21  1:31 ` [PATCH 0/7 v3] overlay filesystem prototype Neil Brown
2010-09-22  9:50   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100930215114.GD490@shell \
    --to=vaurora@redhat.com \
    --cc=agruen@suse.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxram@us.ibm.com \
    --cc=miklos@szeredi.hu \
    --cc=neilb@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).