From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 02/17] fs: icache lock s_inodes list Date: Fri, 1 Oct 2010 01:49:09 -0400 Message-ID: <20101001054909.GB32349@infradead.org> References: <1285762729-17928-1-git-send-email-david@fromorbit.com> <1285762729-17928-3-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Content-Disposition: inline In-Reply-To: <1285762729-17928-3-git-send-email-david@fromorbit.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Sep 29, 2010 at 10:18:34PM +1000, Dave Chinner wrote: > From: Nick Piggin > > To allow removal of the inode_lock, we first need to protect the > superblock inode list with it's own lock instead of using the > inode_lock for this purpose. Nest the new sb_inode_list_lock inside > the inode_lock around the list operations it needs to protect. Is there any good reason not to make this lock per-superblock?