From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: overlayfs: BUG in ovl_whiteout
Date: Mon, 4 Oct 2010 18:33:43 +0100 [thread overview]
Message-ID: <20101004173343.GA19733@agent57> (raw)
In-Reply-To: <E1P2hGO-0001kL-Gw@pomaz-ex.szeredi.hu>
On Mon, Oct 04, 2010 at 11:23:16AM +0200, Miklos Szeredi wrote:
> On Fri, 1 Oct 2010, Andy Whitcroft wrote:
> > I have been playing with overlayfs for a bit now and there seems to
> > be something a little dodgy when unmounting and remounting an overlay.
> > I modified some files in the overlay, immediatly unmounted the overlay and
> > again immediatly remounted it. On touching the same files in the overlay
> > I triggered the following BUG (dmesg fragment at the bottom of this email).
> > When trying to reproduce this I also triggered a hard hang.
>
> Thanks for the bug report, Andy.
>
> Please change that BUG_ON to a WARN_ON. This will make this a
> harmless error message in the log instead of a hang.
Applied your patch to move these to WARN_ON. Now I get a WARN_ON after
the remount. Now that we don't explode I get the following error from
the triggering command. I assume that this is the rename which has
triggered the issue:
W: Failed to fetch http://192.168.0.60:3142/archive.ubuntu.com/ubuntu/dists/maverick/Release rename failed, File exists (/var/lib/apt/lists/192.168.0.60:3142_archive.ubuntu.com_ubuntu_dists_maverick_Release -> /var/lib/apt/lists/192.168.0.60:3142_archive.ubuntu.com_ubuntu_dists_maverick_Release).
I note that the file does indeed exist as a real file in both layers. I
have not as yet managed to generate a naive test that also triggers
this.
-apw
next prev parent reply other threads:[~2010-10-04 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 18:07 overlayfs: BUG in ovl_whiteout Andy Whitcroft
2010-10-04 9:23 ` Miklos Szeredi
2010-10-04 17:33 ` Andy Whitcroft [this message]
2010-10-04 20:16 ` Miklos Szeredi
2010-10-06 12:29 ` Andy Whitcroft
2010-10-06 16:51 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101004173343.GA19733@agent57 \
--to=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).