From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 02/11] quota: Convert dq_state_lock to per-sb dq_state_lock Date: Wed, 6 Oct 2010 12:04:54 +0200 Message-ID: <20101006100453.GC3676@quack.suse.cz> References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com> <1286302827-31043-3-git-send-email-dmonakhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org, Dmitry Monakhov To: Dmitry Monakhov Return-path: Received: from cantor.suse.de ([195.135.220.2]:50984 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140Ab0JFKFt (ORCPT ); Wed, 6 Oct 2010 06:05:49 -0400 Content-Disposition: inline In-Reply-To: <1286302827-31043-3-git-send-email-dmonakhov@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The patch is OK, just some mistakes in the changelog: On Tue 05-10-10 22:20:18, Dmitry Monakhov wrote: > Currently dq_state_lock is global, which is bad for scalability. > In fact different super_blocks has no shared quota's data. ^^^ have ^^^^^^^ without "'s" > So we may simply convert global lock to per-sb lock. ^ the ^^^^ locks Honza -- Jan Kara SUSE Labs, CR