From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 04/11] quota: make dquot lists per-sb Date: Wed, 6 Oct 2010 12:22:24 +0200 Message-ID: <20101006102224.GE3676@quack.suse.cz> References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com> <1286302827-31043-5-git-send-email-dmonakhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz, hch@infradead.org, Dmitry Monakhov To: Dmitry Monakhov Return-path: Received: from cantor.suse.de ([195.135.220.2]:51421 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010Ab0JFKXU (ORCPT ); Wed, 6 Oct 2010 06:23:20 -0400 Content-Disposition: inline In-Reply-To: <1286302827-31043-5-git-send-email-dmonakhov@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue 05-10-10 22:20:20, Dmitry Monakhov wrote: > Currently quota lists are global which is very bad for scalability. > * inuse_lists -> sb->s_dquot->dq_inuse_list > * free_lists -> sb->s_dquot->dq_free_lists > * Add per sb lock for quota's lists protection > > Do not remove dq_lists_lock is used now only for protecting quota_hash Hmm, wouldn't be it easier to just convert lists to per-sb ones in this patch, convert hash in the next patch, and convert the spinlock in the last one. You wouldn't have to have both spinlocks in parallel... But that's just a nit ;). Honza -- Jan Kara SUSE Labs, CR