From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Subject: Re: [PATCH 04/11] quota: make dquot lists per-sb Date: Wed, 6 Oct 2010 12:54:54 +0200 Message-ID: <20101006105454.GH3676@quack.suse.cz> References: <1286302827-31043-1-git-send-email-dmonakhov@gmail.com> <1286302827-31043-5-git-send-email-dmonakhov@gmail.com> <20101006102224.GE3676@quack.suse.cz> <87zkur8v09.fsf@dmon-lap.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , linux-fsdevel@vger.kernel.org, hch@infradead.org, Dmitry Monakhov To: Dmitry Return-path: Received: from cantor2.suse.de ([195.135.220.15]:48425 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754318Ab0JFKzu (ORCPT ); Wed, 6 Oct 2010 06:55:50 -0400 Content-Disposition: inline In-Reply-To: <87zkur8v09.fsf@dmon-lap.sw.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 06-10-10 14:40:06, Dmitry wrote: > On Wed, 6 Oct 2010 12:22:24 +0200, Jan Kara wrote: > > On Tue 05-10-10 22:20:20, Dmitry Monakhov wrote: > > > Currently quota lists are global which is very bad for scalability. > > > * inuse_lists -> sb->s_dquot->dq_inuse_list > > > * free_lists -> sb->s_dquot->dq_free_lists > > > * Add per sb lock for quota's lists protection > > > > > > Do not remove dq_lists_lock is used now only for protecting quota_hash > > Hmm, wouldn't be it easier to just convert lists to per-sb ones in this > > patch, convert hash in the next patch, and convert the spinlock in the last > > one. You wouldn't have to have both spinlocks in parallel... But that's > > just a nit ;). > I've hoped that this would be easier to read and review. > IMHO This that approach one may understand my ideas just by looking > to diff. Well, code-wise it would be easier to review if the patches were split as I suggested and the intentions could be explained in the changelog... > But if you want i can destroy and reassemble locking logic in > one patch :) You don't have to redo the patch. In this case, it's simple enough to verify with your split as well. My comment was mostly meant as a suggestion for future... Honza -- Jan Kara SUSE Labs, CR